@W-17281128@ Reworked interaction between -v and -f #1676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
99
to
101
| protected createDependencies(view: View, outputFiles: string[] = []): RunDependencies { | ||
| const uxDisplay: UxDisplay = new UxDisplay(this, this.spinner); | ||
| const resultsViewer: ResultsViewer = createResultsViewer(view, outputFiles, uxDisplay); |
Contributor
There was a problem hiding this comment.
Does the view come in as undefined or null now? If so, can you please make this obvious by updating the input type to be View|undefined on line 85, 99 and on line 139.
Contributor
There was a problem hiding this comment.
that is
parsedFlags.view as View
should be
parsedFlags.view as View|undefined
right?
stephen-carter-at-sf
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.